Repository navigation
fix(web): tolerate external project script ids in keybinding commands - #112
Merged
lastobelus merged 2 commits intoAug 27, 2026
Merged
Conversation
The server accepts any non-empty trimmed string as a ProjectScript id, but the client's SCRIPT_RUN_COMMAND_PATTERN only allowed lowercase slugs of up to 24 characters. An id dispatched over the API (e.g. a UUID) made commandForProjectScript throw during render, crashing every thread view and the project settings panel with no way to repair from the UI. Relax the pattern's middle segment to TrimmedNonEmptyString, matching the server-side constraint. UI-generated ids are still slugs via nextProjectScriptId, so nothing changes for normal usage; existing keybinding rules keep decoding. Fixes pingdotgg#7851 Worked on by ox-alpha via the pi coding agent harness. (cherry picked from commit 6be823d)
lastobelus
force-pushed
the
port/upstream/pr-7961-tolerate-project-script-ids
branch
from
August 27, 2026 20:46
5956bf5 to
f0434c7
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
left a comment
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5956bf5b6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
commented
Aug 27, 2026
Owner
Author
|
@codex review |
commented
Aug 27, 2026
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
lastobelus
deleted the
port/upstream/pr-7961-tolerate-project-script-ids
branch
August 27, 2026 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
6be823df41b105ddee33677f0b72aa4f5ad1c868ProjectScriptcontractIncident
A saved action in a LastCode server environment used ID
build-intel-package-macos(25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwingExpected a string matching template literal partsin both thread controls and Project Settings.No persisted project data was changed or migrated.
Validation
git diff --checkProvenance
cherry-pick -xRefs #103